• pivot_root@lemmy.world
    link
    fedilink
    arrow-up
    45
    arrow-down
    3
    ·
    edit-2
    23 hours ago

    That code is so wrong. We’re talking about Jason “Thor” Hall here—that function should be returning 1 and 0, not booleans.

    If you don't get the joke...

    In the source code for his GameMaker game, he never uses true or false. It’s always comparing a number equal to 1.

    • Aqarius@lemmy.world
      link
      fedilink
      arrow-up
      6
      ·
      19 hours ago

      Frankly, it’s what I did, too, after coming out of Uni-level C.

      My code was goddamn unreadable.

      • pivot_root@lemmy.world
        link
        fedilink
        arrow-up
        8
        ·
        edit-2
        16 hours ago

        It’s the same for a lot of people. Beginners are still learning good practices for maintainable code, and they’re expected to get better over time.

        The reason people are ragging on PirateSoftware/Jason/Thor isn’t because he’s bad at writing code. It’s because he’s bad at writing code, proclaiming to be an experienced game development veteran, and doubling down and making excuses whenever people point out where his code could be better.

        Nobody would have cared if he admitted that he has some areas for improvement, but he seemingly has to flaunt his overstated qualifications and act like the be-all, end-all, know-it-all of video game development. I’m more invested in watching the drama unfold than I should be, but it’s hard not to appreciate the schadenfreude from watching arrogant influencers destroy their reputation.

        • JackbyDev@programming.dev
          link
          fedilink
          English
          arrow-up
          3
          ·
          8 hours ago

          He’s totally one of those people that’s sort of attractive and has an authoritative voice so s lot of people have probably folded to him in arguments through his life. I don’t like making generalizations like that about people but this isn’t the first time he’s acted like this. The one that really took the cake was the whole hardcore WoW raid debacle.

          The TL;DR is, as well as not trying to really spend time on the parts that don’t matter, he did some things that may or may not have been the right thing to do in the situation depending on your perspective. But whenever any of his guild mates or other viewers would criticize him he’d be so adamant that no, he didn’t do anything wrong, he did exactly what he was supposed to do, etc. People would even explicitly tell him “hey, what’s pissing us off now isn’t that you did it, it’s that you’re so adamant you couldn’t have possibly made a mistake, you’re not willing to see our perspective. You’re not willing to admit that maybe you could’ve been wrong. You’re not willing to apologize.” And still, his reaction to this was to triple down and just insist he didn’t do anything wrong.

          Like I literally even saw a clip of him talking to someone and he said “a lot of people think I’m being condescending when really I’m just providing context.” And the guy talking to him points out “yeah, it’s a problem that you think anyone disagreeing with you doesn’t understand the situation, it’s like you think they’re stupid.” It’s like it short circuited his brain. It’s like he’d never considered it.

          So yeah, I have a pretty low opinion of him. But I also recognize that maybe all these clips are taken out of context, who knows. It’s not like my opinion really matters. I don’t work with him or know him. I don’t care about streamers. I don’t really watch them.

      • Croquette@sh.itjust.works
        link
        fedilink
        arrow-up
        5
        ·
        18 hours ago

        I am working with C in embedded designs and I still use 1 or 0 for a bool certain situations, mostly lines level.

        For whatever pea-brained reason, it feels yucky to me to set a gpio to true/false instead of a 1/0.

        • xthexder@l.sw0.com
          link
          fedilink
          arrow-up
          6
          ·
          edit-2
          17 hours ago

          GPIOs are usually controlled by a single bit of a register anyway. Most likely you need to do something like:

          // Set high
          PORTB |= 1 << PINB5;
          // Set low
          PORTB &= ~(1 << PINB5);
          
          • Croquette@sh.itjust.works
            link
            fedilink
            arrow-up
            2
            ·
            15 hours ago

            I am a lazy dev (not really, clients always want fast code), so I use the provided HAL libraries 99.9% of the time.

            But I have seen code where someone would write something like

            gpio_write(PIN_X, true) 
            

            and it always stood out to me.

            • JackbyDev@programming.dev
              link
              fedilink
              English
              arrow-up
              1
              ·
              8 hours ago

              Define on as true or something? Or maybe that’s more confusing. I’m not a C dev so I’m not gonna pretend to understand idiomatic microcontroller code lol.

              • Croquette@sh.itjust.works
                link
                fedilink
                arrow-up
                1
                ·
                2 hours ago

                Sometimes, people do that. But using 0/1 is explicit enough since you can refer to a line as ‘1’ or ‘0’ for high/low on the hardware as well